[Console] Send the right exit code to console.terminate listeners #28545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3.4 does not have this bug, most likely due to #22441 |
|
at least tests fail :) |
|
@nicolas-grekas Will work on tests if you agree we should fix it on 2.8. |
|
We might also just wait for 2.8 to fade out if you don't have time to work on this :) |
|
I was expecting this :-) Personally, I‘ll probably have to deal with 2.8 for another year so I‘d be glad to have this fixed. |
|
@nicolas-grekas Tests added – does it make sense to omit the |
nicolas-grekas
approved these changes
Sep 23, 2018
chalasr
approved these changes
Sep 23, 2018
79066c8 to
b90a3f1
Compare
|
Thank you @mpdude. |
chalasr
pushed a commit
that referenced
this pull request
Sep 23, 2018
…steners (mpdude) This PR was squashed before being merged into the 2.8 branch (closes #28545). Discussion ---------- [Console] Send the right exit code to console.terminate listeners | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When a Console command throws an exception without a status code, `Application::run()` takes care of setting the exit code to `1` when the exception does not provide a code itself. This happens slightly too late, as `console.terminate` event listeners that are called from within `Application::doRunCommand()` are given the plain exeception code, before this conversion. The result is that `console.*` event listeners that you might be using to log exit code e. g. for cron jobs will see a `0` code instead of the real value used to terminate the script. ***Todo:*** - [x] Make sure we've got tests covering this, i. e. do not mock out `doRunCommand()`. Commits ------- b90a3f1 [Console] Send the right exit code to console.terminate listeners
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Console command throws an exception without a status code,
Application::run()takes care of setting the exit code to1when the exception does not provide a code itself.This happens slightly too late, as
console.terminateevent listeners that are called from withinApplication::doRunCommand()are given the plain exeception code, before this conversion.The result is that
console.*event listeners that you might be using to log exit code e. g. for cron jobs will see a0code instead of the real value used to terminate the script.Todo:
doRunCommand().