[Translation] marked getFallbackLocales() as internal #28626

boscho87 · 2018-09-27T20:51:38Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#28579
License	MIT
Doc PR

Added the deprication trigger error function to getFallbackLocales in the Translation component.

(Its my first PR, please tell me if i need to change something)

nicolas-grekas

Thanks for starting this. Would you mind having a look at where this method is used in the code base and remove/replace them?

nicolas-grekas · 2018-09-27T21:38:57Z

CHANGELOG-4.1.md

@@ -8,7 +8,7 @@ To get the diff for a specific change, go to https://github.com/symfony/symfony/
 To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v4.1.0...v4.1.1

 * 4.1.4 (2018-08-28)
-
+ * deprecation #28579 [Translator] set the getFallbackLocales() method as deprecated (boscho87)


This file is autogenerated so all changes should be reverted. But the changelog in the component itself should be updated instead.

thus, a PR to master would not change the existing 4.1.4 release

src/Symfony/Component/Translation/CHANGELOG.md

stof

The file mode change on the different php files must be reverted too.

If you are on Windows, here is the way to go:

# configure git to avoid doing such mess in the future
git config --global core.fileMode false

# change the mode back for these files
git update-index --chmod=-x path/to/file.ext

src/Symfony/Component/Translation/CHANGELOG.md

stof · 2018-09-28T08:00:18Z

src/Symfony/Component/Translation/DataCollector/TranslationDataCollector.php

    public function getFallbackLocales()
    {
+        @trigger_error('getFallbackLocales() is deprecated since version 4.1 and will be removed in 5.0.', E_USER_DEPRECATED);


deprecation is in 4.2, not in 4.1. We cannot deprecate it in 4.1 as it is already released since 4 months.

@stof tahnk you for your effort to teaching me! (i will work on this tomorrow 👍 )

boscho87 · 2018-09-28T19:52:59Z

@nicolas-grekas i do not find any usages...
@stof i changed the files (i use linux not Windows)

nicolas-grekas · 2018-09-29T20:41:44Z

Running grep getFallbackLocales src/ -rl on the repository spots the usages, that's where we should start.
On Linux, you should use chmod 644 with the name of each file (honestly, I don't know how you ended up changing the mode of these files, maybe some unusual configuration like @stof hinted about?)

boscho87 · 2018-09-29T21:10:05Z

Idk i never before had such problems with changing file permisssions

fabpot · 2018-09-30T04:22:22Z

CHANGELOG-4.1.md

@@ -331,7 +330,7 @@ To get the diff between two versions, go to https://github.com/symfony/symfony/c
 * feature #24778 [BrowserKit] add a way to switch to ajax for one request (Simperfit)
 * feature #25605 [PropertyInfo] Added support for extracting type from constructor (lyrixx)
 * feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)
- * feature #25218 [Serializer] add a constructor arguement to return csv always as collection  (Simperfit)
+ * feature #25218 [Serializer] add a constructor argument to return csv always as collection  (Simperfit)


The changes in this file should be reverted as it is auto-generated.

boscho87 · 2018-09-30T11:03:20Z

Maybe i should not have started this PR... im a bit confused what is need to be done exactly..

e.g https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php#L321 here ... should this whole method all so be removed and all the stuff who uses tha catalouges too https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php#L200

nicolas-grekas · 2018-09-30T20:08:55Z

I think there is an easy way to finish this PR, which is reverting the deprecation and add @internal since Symfony 4.2 on the method instead. This would provide the same.

fabpot · 2018-10-03T07:54:51Z

Thank you @boscho87.

…(boscho87) This PR was merged into the 4.2-dev branch. Discussion ---------- [Translation] marked getFallbackLocales() as internal | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #28579 | License | MIT | Doc PR | Added the deprication trigger error function to getFallbackLocales in the Translation component. (Its my first PR, please tell me if i need to change something) Commits ------- 9d67a68 [Translation] marked getFallbackLocales() as internal

boscho87 · 2018-10-03T10:03:04Z

@fabpot @nicolas-grekas
Thanks for support

Was a small one but my first

Hope i can do „bigger things“ in the future

This PR was merged into the 4.2 branch. Discussion ---------- Drop spurious execution bit | Q | A | ------------- | --- | Branch? | 4.2 for bug fixes | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none The execution bit seems to have been added by mistake in #28626. Commits ------- 93dab5c Drop spurious execution bit

carsonbot added Status: Needs Review Deprecation labels Sep 27, 2018

nicolas-grekas reviewed Sep 27, 2018

View reviewed changes

src/Symfony/Component/Translation/CHANGELOG.md Outdated Show resolved Hide resolved

stof requested changes Sep 28, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Sep 28, 2018

stof added this to the next milestone Sep 28, 2018

fabpot requested changes Sep 30, 2018

View reviewed changes

boscho87 changed the title ~~added deprication to getFallbackLocales~~ added deprecation to getFallbackLocales Sep 30, 2018

nicolas-grekas approved these changes Oct 2, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Oct 2, 2018

nicolas-grekas changed the title ~~added deprecation to getFallbackLocales~~ [Translation] marked getFallbackLocales() as internal Oct 2, 2018

[Translation] marked getFallbackLocales() as internal

9d67a68

fabpot approved these changes Oct 3, 2018

View reviewed changes

fabpot merged commit 9d67a68 into symfony:master Oct 3, 2018

boscho87 deleted the deprication/getFallbackLocales branch October 4, 2018 13:10

nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018

fabpot mentioned this pull request Nov 3, 2018

Release v4.2.0-BETA1 #29072

Closed

fabpot mentioned this pull request Nov 3, 2018

Release v4.2.0-BETA1 #29073

Merged

DavidPrevot mentioned this pull request Feb 27, 2019

Drop spurious execution bit #30399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Translation] marked getFallbackLocales() as internal #28626

[Translation] marked getFallbackLocales() as internal #28626

boscho87 commented Sep 27, 2018 •

edited by stof

Loading

nicolas-grekas left a comment

nicolas-grekas Sep 27, 2018

stof Sep 28, 2018

stof left a comment

stof Sep 28, 2018

boscho87 Sep 28, 2018

boscho87 commented Sep 28, 2018

nicolas-grekas commented Sep 29, 2018 •

edited

Loading

boscho87 commented Sep 29, 2018

fabpot Sep 30, 2018

boscho87 commented Sep 30, 2018

nicolas-grekas commented Sep 30, 2018

fabpot commented Oct 3, 2018

boscho87 commented Oct 3, 2018 •

edited

Loading

[Translation] marked getFallbackLocales() as internal #28626

[Translation] marked getFallbackLocales() as internal #28626

Conversation

boscho87 commented Sep 27, 2018 • edited by stof Loading

nicolas-grekas left a comment

Choose a reason for hiding this comment

nicolas-grekas Sep 27, 2018

Choose a reason for hiding this comment

stof Sep 28, 2018

Choose a reason for hiding this comment

stof left a comment

Choose a reason for hiding this comment

stof Sep 28, 2018

Choose a reason for hiding this comment

boscho87 Sep 28, 2018

Choose a reason for hiding this comment

boscho87 commented Sep 28, 2018

nicolas-grekas commented Sep 29, 2018 • edited Loading

boscho87 commented Sep 29, 2018

fabpot Sep 30, 2018

Choose a reason for hiding this comment

boscho87 commented Sep 30, 2018

nicolas-grekas commented Sep 30, 2018

fabpot commented Oct 3, 2018

boscho87 commented Oct 3, 2018 • edited Loading

boscho87 commented Sep 27, 2018 •

edited by stof

Loading

nicolas-grekas commented Sep 29, 2018 •

edited

Loading

boscho87 commented Oct 3, 2018 •

edited

Loading