Skip to content

Deprecate Translation::getFallbackLocales() #28579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Sep 24, 2018 · 0 comments
Closed

Deprecate Translation::getFallbackLocales() #28579

nicolas-grekas opened this issue Sep 24, 2018 · 0 comments
Labels
Deprecation Translation

Comments

@nicolas-grekas
Copy link
Member

From #25549 (comment)

getFallbackLocales only fits reflection purposes in the code base. We'd better deprecate it actually and find another way for data collectors and debug:translation. Let's reduce the complexity.

The current places that use it should instead be provided with the same options/locales/fallbacks as the translator.
This was referenced Sep 24, 2018
Closed
Closed
@boscho87 boscho87 mentioned this issue Sep 27, 2018
Merged
fabpot added a commit that referenced this issue Oct 3, 2018
@fabpot
feature #28626 [Translation] marked getFallbackLocales() as internal …
679f8d9 
…(boscho87)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Translation] marked getFallbackLocales() as internal

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #28579
| License       | MIT
| Doc PR        |

Added the deprication trigger error function to getFallbackLocales in the Translation component.

(Its my first PR, please tell me if i need to change something)

Commits
-------

9d67a68 [Translation] marked getFallbackLocales() as internal
@fabpot fabpot closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @nicolas-grekas