-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] deprecate some options for single_text widgets #28721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-grekas
merged 1 commit into
symfony:master
from
xabbuh:datetime-type-singletext-deprecations
Jan 27, 2019
Merged
[Form] deprecate some options for single_text widgets #28721
nicolas-grekas
merged 1 commit into
symfony:master
from
xabbuh:datetime-type-singletext-deprecations
Jan 27, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 4, 2018
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | yes |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
3681b21
to
29f1daf
Compare
29f1daf
to
65a765e
Compare
HeahDude
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice move, I like that 👍
yceruto
reviewed
Oct 4, 2018
src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
Outdated
Show resolved
Hide resolved
c1bc7a2
to
d10e7a7
Compare
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
…ion closure (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28738). Discussion ---------- [OptionsResolver] Passing Options argument to deprecation closure | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28721 (comment) | License | MIT | Doc PR | symfony/symfony-docs#10439 As spotted here #28721, we sometimes need more advanced cases, where the deprecation of the value depends on another option: ```php $resolver->setDeprecated('date_format', function (Options $options, $dateFormat) { if (null !== $options['date_format'] && 'single_text' === $options['widget']) { return sprintf('Using the "date_format" option of the %s when the "widget" option is set to "single_text" is deprecated since Symfony 4.2.', self::class); } return ''; }); ``` There is still a decision to make: > We're in time to change the arguments position (Options $options, $value) to be consistent with other closure signatures. WDYT? Commits ------- 2936051 [OptionsResolver] Passing Options argument to deprecation closure
Status: Needs work |
d10e7a7
to
11f32ca
Compare
11f32ca
to
3f951a5
Compare
Status: Needs Review |
3f951a5
to
882a4cc
Compare
nicolas-grekas
approved these changes
Oct 20, 2018
fabpot
requested changes
Oct 21, 2018
src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
Outdated
Show resolved
Hide resolved
882a4cc
to
81b3d9a
Compare
81b3d9a
to
e9cbc61
Compare
241290a
to
0ab3e8d
Compare
Status: Needs Review |
0ab3e8d
to
89ff331
Compare
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2019
…(xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [Form] deprecate some options for single_text widgets | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 89ff331 deprecate some options for single_text widgets
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 7, 2019
…iereguiluz) This PR was merged into the master branch. Discussion ---------- Added a note about the deprecations of DateTimeType Documents symfony/symfony#28721. Commits ------- 89f0296 Added a note about the deprecations of DateTimeType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.