[OptionsResolver] Passing Options argument to deprecation closure #28738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, let's do that. Otherwise, it will become hard to remember when arguments are passed in which order. |
db8d2b4 to
2d531b3
Compare
c903fdb to
21b9aa3
Compare
|
@xabbuh comments addressed. I'm preparing the doc PR right now. |
javiereguiluz
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Useful feature, nicely developed and fully documented. @yceruto thanks a lot for doing things so nice!
fabpot
approved these changes
Oct 10, 2018
532b6bd to
2936051
Compare
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
…ion closure (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28738). Discussion ---------- [OptionsResolver] Passing Options argument to deprecation closure | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28721 (comment) | License | MIT | Doc PR | symfony/symfony-docs#10439 As spotted here #28721, we sometimes need more advanced cases, where the deprecation of the value depends on another option: ```php $resolver->setDeprecated('date_format', function (Options $options, $dateFormat) { if (null !== $options['date_format'] && 'single_text' === $options['widget']) { return sprintf('Using the "date_format" option of the %s when the "widget" option is set to "single_text" is deprecated since Symfony 4.2.', self::class); } return ''; }); ``` There is still a decision to make: > We're in time to change the arguments position (Options $options, $value) to be consistent with other closure signatures. WDYT? Commits ------- 2936051 [OptionsResolver] Passing Options argument to deprecation closure
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 12, 2018
…re deprecation func (yceruto) This PR was merged into the master branch. Discussion ---------- [OptionsResolver] Documenting Options argument for closure deprecation func See symfony/symfony#28738 Commits ------- abb5189 Documenting Options argument for closure deprecation func
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted here #28721, we sometimes need more advanced cases, where the deprecation of the value depends on another option:
There is still a decision to make:
WDYT?