[FWBundle] Automatically enable PropertyInfo when using Flex #28735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It wasn't qualified as a bug in #27429 though |
|
Ohhh. So this was already fixed... but on master. I can see arguments both ways about a bug or a feature. This PR was motivated by me being confused by this yesterday... but it could also be “helped” on 3.4 and 4.1 by adding docs about activating it. |
fabpot
approved these changes
Oct 6, 2018
|
Apparently, tests are broken. |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Oct 8, 2018
…ex (dunglas) This PR was merged into the 3.4 branch. Discussion ---------- [FWBundle] Automatically enable PropertyInfo when using Flex | Q | A | ------------- | --- | Branch? | 3.4 Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Automatically enabling PropertyInfo when using Flex and when the component is installed has been forgotten when releasing 3.4. It makes it very hard to debug why some features of the serializer are sometimes not working properly. Commits ------- 0683f0a [FWBundle] Automatically enable PropertyInfo when using Flex
|
See #28762 for tests |
fabpot
added a commit
that referenced
this pull request
Oct 8, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix 3.4 tests | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes (AppVeyor failure unrelated) <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Should fix tests on 3.4 branch after #28735 being merged. Also updates the check for consistency with https://github.com/symfony/symfony/pull/27429/files#diff-5e7347edce37c5886ec67b7ba02f3a9cR837 on master. Commits ------- 3b99a0d [FrameworkBundle] Fix 3.4 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically enabling PropertyInfo when using Flex and when the component is installed has been forgotten when releasing 3.4.
It makes it very hard to debug why some features of the serializer are sometimes not working properly.