Skip to content

[WebServerBundle] Deprecate relying on --env in server:start and server:run #28745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Oct 5, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@fabpot
Copy link
Member

fabpot commented Oct 6, 2018

Thank you @chalasr.

@fabpot fabpot merged commit 31b5615 into symfony:master Oct 6, 2018
fabpot added a commit that referenced this pull request Oct 6, 2018
…:start and server:run (chalasr)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[WebServerBundle] Deprecate relying on --env in server:start and server:run

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

31b5615 [WebServerBundle] Deprecate relying on --env in server:start and server:run
@chalasr chalasr deleted the srv-env branch October 6, 2018 13:30
This was referenced Nov 3, 2018
@nicolas-grekas
Copy link
Member

Reverted in #29204

nicolas-grekas added a commit that referenced this pull request Nov 14, 2018
…-env and --no-debug console options (chalasr)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options

This reverts commit 9f60ff8.
This reverts commit 31b5615.

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28984
| License       | MIT
| Doc PR        | -

Working on recipes with @weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.

Same as #29126, reverts #28745 and #28653

Commits
-------

443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants