[TwigBundle] Deprecating support for legacy templates directories #28891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb92d3d to
4ad6e4a
Compare
ogizanagi
reviewed
Oct 16, 2018
| @@ -115,14 +116,18 @@ public function load(array $configs, ContainerBuilder $container) | |||
| } | |||
|
|
|||
| if (file_exists($dir = $container->getParameter('kernel.root_dir').'/Resources/views')) { | |||
| if ($dir !== $defaultTwigPath) { | |||
| @trigger_error(sprintf('"%s" This templates directory is deprecated since 4.2, use "%s" instead.', $dir, $defaultTwigPath), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
- "%s" This templates directory is deprecated since 4.2, use "%s" instead.
+ Templates directory "%s" is deprecated since 4.2, use "%s" instead.? (same below)
4ad6e4a to
4f5ed6d
Compare
|
Ready! (AppVeyor failure is unrelated) |
xabbuh
reviewed
Oct 16, 2018
4f5ed6d to
e0da5ac
Compare
ro0NL
reviewed
Oct 17, 2018
src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php
Show resolved
Hide resolved
Yeah, in 5.0 :)
It's part of the Templating layer of the FB, no related IMO. |
chalasr
reviewed
Oct 17, 2018
src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
Outdated
Show resolved
Hide resolved
e0da5ac to
acae8bb
Compare
|
@chalasr comments addressed, thanks. (Ready) |
ro0NL
reviewed
Oct 17, 2018
src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php
Outdated
Show resolved
Hide resolved
acae8bb to
8b390f3
Compare
nicolas-grekas
approved these changes
Oct 20, 2018
fabpot
approved these changes
Oct 21, 2018
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 21, 2018
…directories (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [TwigBundle] Deprecating support for legacy templates directories | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10500 go ahead with #28810 (comment) - [x] Fix tests Commits ------- 8b390f3 Deprecating support for legacy templates directories
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 23, 2018
…uto) This PR was merged into the master branch. Discussion ---------- Deprecating support for legacy templates directory Update according to symfony/symfony#28891 Commits ------- a90ae14 Deprecating support for legacy templates directory
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
…om legacy directories (yceruto) This PR was merged into the 5.0-dev branch. Discussion ---------- [TwigBundle] Removed capability to load Twig template from legacy directories | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ref #28891 Commits ------- 4b6752b Removed capability to load Twig template from legacy directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go ahead with #28810 (comment)