Skip to content

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() #29154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() #29154

merged 1 commit into from
Nov 10, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Nov 9, 2018

Q A
Branch? 4.2
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28984, #29126
License MIT
Doc PR todo

Replaces #29126.

@chalasr chalasr added this to the 4.2 milestone Nov 9, 2018
@chalasr chalasr changed the title [Console] Add Application::bootstrapEnv() [Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() Nov 9, 2018
@chalasr chalasr mentioned this pull request Nov 9, 2018
Closed
ro0NL
ro0NL reviewed Nov 9, 2018
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Nov 9, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks :)

@nicolas-grekas nicolas-grekas mentioned this pull request Nov 9, 2018
Merged
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 9, 2018 •
edited
Loading

Two more ideas:

  • add before/after for bin/console in UPGRADE files
  • bump symfony/console to 4.2 (in require-dev and conflict) so that we're sure to get console 4.2 when fwb 4.2 is installed (will make the recipe much simpler)

@chalasr
Copy link
Member Author

chalasr commented Nov 9, 2018

@nicolas-grekas updated, thanks

nicolas-grekas
nicolas-grekas approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@chalasr chalasr changed the title [Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() Nov 9, 2018
nicolas-grekas
nicolas-grekas approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I agree, too opinionated for a component :)

@nicolas-grekas nicolas-grekas mentioned this pull request Nov 9, 2018
Merged
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 10, 2018 •
edited
Loading

I'm merging quickly so that the recipes work with 4.2 (they're broken for now.)
It will allow us to play with the new experience more easily to ensure 4.2 will be smooth.
If you have more comments here, please do post them and I'll ensure they're resolved asap.

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit bbd5682 into symfony:master Nov 10, 2018
nicolas-grekas added a commit that referenced this pull request Nov 10, 2018
@nicolas-grekas
bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via A…
9253199 
…pplication::bootstrapEnv() (chalasr)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28984, #29126
| License       | MIT
| Doc PR        | todo

Replaces #29126.

Commits
-------

bbd5682 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 10, 2018
Closed
@chalasr chalasr deleted the cli-bootstrapenv branch November 10, 2018 11:03
@fmata fmata mentioned this pull request Nov 10, 2018
Merged
@fmata
Copy link
Contributor

fmata commented Nov 10, 2018

I fixed a minor doc issue + removed \count() calls in #29164.

nicolas-grekas added a commit that referenced this pull request Nov 10, 2018
@nicolas-grekas
minor #29164 [FrameworkBundle] Application::bootstrapEnv() minor twea…
a7fe4bf 
…ks (fmata)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle] Application::bootstrapEnv() minor tweaks

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Just 2 minor tweaks to #29154 caught while reviewing.

Commits
-------

4e92e6e [FrameworkBundle] Application::bootstrapEnv() upgrade doc fix
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Nov 12, 2018
@nicolas-grekas
Revert "bug symfony#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG …
f3c5fda 
…from argv via Application::bootstrapEnv() (chalasr)"

This reverts commit 9253199, reversing
changes made to 664a032.
nicolas-grekas added a commit that referenced this pull request Nov 13, 2018
@nicolas-grekas
bug #29197 Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DE…
0e242ab 
…BUG from argv via Application::bootstrapEnv() (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()

This reverts commit 9253199, reversing
changes made to 664a032.

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Replaced by symfony/recipes#491, see description there.

Commits
-------

f3c5fda Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() (chalasr)"
@fabpot fabpot mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @nicolas-grekas @fmata @ro0NL @carsonbot