[Workflow] Add colors to workflow dumps #29538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Dec 10, 2018
ro0NL
reviewed
Dec 13, 2018
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/workflows.php
Outdated
Show resolved
Hide resolved
Kronhyx
approved these changes
Dec 13, 2018
|
The last two examples on this page shows the dot format, with So the option |
03eb8fe to
31e9564
Compare
|
Can someone please remove the |
31e9564 to
0b54bcb
Compare
|
rebase needed due to short arrays. |
4698c38 to
ebe5385
Compare
|
Thanks for hint, the PR has been rebased. |
|
@lyrixx I think we need your help to move forward here. |
|
Thanks @alexislefebvre . This is very Good. Could you rebase before the merge ? (I think this will conflict with #30468 but I will take care of it). Could someone review English textes (PHP Doc, Changelog)? 🙏 Thanks |
ebe5385 to
e12babf
Compare
|
Rebase done. ✔️ Thanks for the follow-up. |
fabpot
reviewed
Mar 14, 2019
84a0553 to
4d313e5
Compare
fabpot
reviewed
Mar 18, 2019
4d313e5 to
0a59b50
Compare
fabpot
approved these changes
Mar 19, 2019
0a59b50 to
60ad109
Compare
|
Thank you @alexislefebvre. |
fabpot
added a commit
that referenced
this pull request
Mar 19, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #29538). Discussion ---------- [Workflow] Add colors to workflow dumps Fixes #28874 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28874, replaces #28933 | License | MIT | Doc PR | TODO, requires symfony/symfony-docs#9476 Fetch data with the `MetadataStore` from #26092 in order to add colors to the dumps. Example of configuration: ```yaml transitions: submit: from: start to: travis metadata: title: transition submit title dump_style: label: 'My custom label' arrow_color: '#0088FF' label_color: 'Red' ``` This code was developed as a bundle, examples can be found on its repository: https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle Commits ------- 60ad109 [Workflow] Add colors to workflow dumps
3 tasks
Merged
This was referenced Jul 7, 2019
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…n (alexislefebvre) This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes #32419). Discussion ---------- [Workflow] Add missing test for workflow dump description | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR add a test for a feature added in #29538 but missed a test. Commits ------- 0c326d0 Add missing test for workflow dump description
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jul 8, 2019
…alexislefebvre) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Explain how to style a workflow dump Fixes symfony#11675 Explain what was added in symfony/symfony#29538 TODO: - [x] Explain keys - [x] Add YAML format - [x] Add XML format - [x] Add PHP format Commits ------- e6c1992 Workflow: explain how to style a workflow dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28874
Fetch data with the
MetadataStorefrom #26092 in order to add colors to the dumps.Example of configuration:
This code was developed as a bundle, examples can be found on its repository: https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle