[Workflow] Added support for many inital places #30468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Mar 6, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #30080 |
| License | MIT |
| Doc PR |
35880b2 to
f623102
Compare
Korbeil
suggested changes
Mar 6, 2019
There was a problem hiding this comment.
Thanks a lot for this PR, this will help us improve how we use workflow 😄
Quick notice, I did not see tests with multiple initial places, I think it should be better to add atleast one.
Also, is there a reason you don't throw an Exception when we have multiple initial places with single_state marking store ?
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Outdated
Show resolved
Hide resolved
I will do that once #29457 is merged. It will be much more easier |
f623102 to
9a9184d
Compare
|
Here we Go. I updated validators and added test 👍 |
9c10c81 to
56c6090
Compare
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
a3ca1b6 to
66119d5
Compare
66119d5 to
1af1bf2
Compare
lyrixx
added a commit
that referenced
this pull request
Mar 22, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Added support for many inital places | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #30080 | License | MIT | Doc PR | Commits ------- 1af1bf2 Added support for many inital places
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Apr 6, 2019
I introduced a BC break in symfony#30468 and this PR fix it. With the full stack framework, when one does not configure the initial_place(s) the DIC set `[]` for the initial values. So it removes the initials values guessed in `Definition::addPlace()`
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Apr 6, 2019
I introduced a BC break in symfony#30468 and this PR fix it. With the full stack framework, when one does not configure the initial_place(s) the DIC set `[]` for the initial values. So it removes the initials values guessed in `Definition::addPlace()`
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…red (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Fixed initial places when no places are configured | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | EUFOSSA I introduced a BC break in #30468 and this PR fix it. With the full stack framework, when one does not configure the initial_place(s) the DIC set `[]` for the initial values. So it removes the initials values guessed in `Definition::addPlace()` Commits ------- 76fd9c3 [Workflow] Fixed initial places when no places are configured
Merged
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
to lyrixx/symfony
that referenced
this pull request
Jun 28, 2019
Added missing part of symfony#30468
lyrixx
added a commit
that referenced
this pull request
Jun 28, 2019
…() (lyrixx) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Deprecated DefinitionBuilder::setInitialPlace() Added missing part of #30468 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4d002e8 [Workflow] Deprecated DefinitionBuilder::setInitialPlace()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.