[DI] Overriding services autowired by name under _defaults bind not working #29944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo in PR headline: - [DI] Fixes: #28326 - Overriding services autowired by name under _deaults bind not working
+ [DI] Fixes: #28326 - Overriding services autowired by name under _defaults bind not working |
GuilhemN
reviewed
Jan 24, 2019
There was a problem hiding this comment.
This is great 👍 I'm only concerned about the PhpFileLoader which doesn't call FileDefinition::setDefinition() (https://github.com/przemyslaw-bogusz/symfony/blob/85a28f1e4e5a6197bbc4ed0550b9ce68936c83bf/src/Symfony/Component/DependencyInjection/Loader/Configurator/ServiceConfigurator.php#L65).
Shouldn't the logic be added there too?
|
See comment in #29949: there may be an issue that makes the container load all classes at compile time. We should avoid it if confirmed. |
85a28f1 to
3bbf849
Compare
|
@GuilhemN Thanks for the suggestion. I added the funcionality for @nicolas-grekas This PR is rather simple so I don't think I've made a change that would cause
At least, I'm not aware of that. |
…er _defaults bind not working
3bbf849 to
5cf6a3f
Compare
nicolas-grekas
approved these changes
Apr 12, 2019
5cf6a3f to
1ad8e81
Compare
1ad8e81 to
7e805ea
Compare
|
Thank you @przemyslaw-bogusz. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2019
… bind not working (przemyslaw-bogusz, renanbr) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Overriding services autowired by name under _defaults bind not working | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28326 | License | MIT This is an implementation of ideas and suggestions of @nicolas-grekas and @GuilhemN. Commits ------- 7e805ea more tests 35a40ac [DI] Fixes: #28326 - Overriding services autowired by name under _defaults bind not working
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2019
…(teohhanhui) This PR was merged into the 3.4 branch. Discussion ---------- Fix name and phpdoc of ContainerBuilder::removeBindings | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29944 (comment) | License | MIT | Doc PR | N/A <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- c93194d Fix name and phpdoc of ContainerBuilder::removeBindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of ideas and suggestions of @nicolas-grekas and @GuilhemN.