[DI] add id of referencing service when a deprecated alias is found #29995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvement! Not sure if it's possible, but I'd reword the error message: like this: |
|
I'd happily improve the message, but your suggestion is not possible, see L65 how the message is constructed. We can only append or prepend to the message conveyed by the alias. |
b0ec032 to
d9cfc13
Compare
|
Note that this PR is renaming the placeholder used in the message. When it gets merged, the blog post published today should be updated to reflect the change. |
d9cfc13 to
b124fb7
Compare
stof
approved these changes
Jan 28, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jan 28, 2019
… is found (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [DI] add id of referencing service when a deprecated alias is found | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Improves #29968 a bit for DX. Commits ------- b124fb7 [DI] add id of referencing service when a deprecated alias is found
|
@nicolas-grekas with your change to move the trigger_error outside the loop, what happens if you have |
yes, because of the loop in process (see L32) |
|
@stof thanks for this warning. The blog post has been updated accordingly. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 29, 2019
…iluz) This PR was squashed before being merged into the master branch (closes #10937). Discussion ---------- Documented the deprecation of service aliases It documents symfony/symfony#29968 but it contains the changes of the pending PR symfony/symfony#29995 Commits ------- d5d87e6 Documented the deprecation of service aliases
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 4, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 4, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 4, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 4, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 5, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 6, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 6, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 6, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 6, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
XuruDragon
pushed a commit
to XuruDragon/symfony
that referenced
this pull request
Feb 7, 2019
…ebug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR symfony#29968 and symfony#29995
nicolas-grekas
added a commit
that referenced
this pull request
Feb 8, 2019
…ed aliases in debug:autowiring (XuruDragon) This PR was merged into the 4.3-dev branch. Discussion ---------- [DependencyInjection] Added information about deprecated aliases in debug:autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR #29968 and #29995  Commits ------- 3d2378d [DependencyInjection] Added information about deprecated aliases in debug:autowiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #29968 a bit for DX.