Skip to content

Update validators.bg.xlf #30227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Update validators.bg.xlf #30227

merged 1 commit into from
Feb 14, 2019

Conversation

LubenZA
Copy link
Contributor

@LubenZA LubenZA commented Feb 13, 2019

Translated 83, 84, & 85

Q A
Branch? master for features / 3.4 up to 4.2 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30151
License MIT
Doc PR symfony/symfony-docs#...

Copy link
Contributor Author

@LubenZA LubenZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Char fix

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @LubenZA for your contribution!

@javiereguiluz
Copy link
Member

@LubenZA I'm sorry to bother you, but this morning we added a new phrase to the translated files. Could you please add this new translation so we complete the Bulgarian translation? Thanks!

<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>

@LubenZA
Copy link
Contributor Author

LubenZA commented Feb 13, 2019

No bother at all - I will translate shortly.

Copy link
Contributor Author

@LubenZA LubenZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 86.

@LubenZA
Copy link
Contributor Author

LubenZA commented Feb 13, 2019

If you need more translations just shout.
Feel free to close when you are happy.

@javiereguiluz
Copy link
Member

@LubenZA thank you! This is now perfectly completed. We'll merge your pull request soon. Thanks.

@fabpot
Copy link
Member

fabpot commented Feb 14, 2019

Thank you @LubenZA.

@fabpot fabpot merged commit 4f3bc6b into symfony:3.4 Feb 14, 2019
fabpot added a commit that referenced this pull request Feb 14, 2019
This PR was squashed before being merged into the 3.4 branch (closes #30227).

Discussion
----------

Update validators.bg.xlf

Translated 83, 84, & 85

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30151
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

4f3bc6b Update validators.bg.xlf
nicolas-grekas added a commit that referenced this pull request Mar 13, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Improve Bulgarian translations.

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

This pull request is an improvement on top of #30227 and improves translations in the following ways:

- Make consistent how `This` word is translated.
- Make consistent how `This value` is translated.
- Fix capitalization rules for abbreviations.
- Change `email` to `имейл` (this is a word in the official Bulgarian dictionary).
- Removes unnecessary words in brackets.

Feel free to comment and criticize I'm not a professional translator.

Commits
-------

d15c76c Make translations consistent with other translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants