Skip to content

Logger reset #30409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Logger reset #30409

wants to merge 5 commits into from

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Feb 28, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no>
Tests pass? yes
Fixed tickets
License MIT
Doc PR

DavidPrevot and others added 4 commits February 26, 2019 17:31
This PR was merged into the 4.2 branch.

Discussion
----------

Drop spurious execution bit

| Q             | A
| ------------- | ---
| Branch?       | 4.2 for bug fixes
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

The execution bit seems to have been added by mistake in symfony#28626.

Commits
-------

93dab5c Drop spurious execution bit
…n Firefox (inmarelibero)

This PR was squashed before being merged into the 4.2 branch (closes symfony#30383).

Discussion
----------

[WebProfilerBundle] toolbar: invisible route name in Firefox

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#29858
| License       | MIT
| Doc PR        | -

This fixes symfony#29858, fixing a bug that prevents Route name displaying in debug toolbar on Firefox

Commits
-------

6b6bd45 [WebProfilerBundle] toolbar: invisible route name in Firefox
@OskarStark
Copy link
Contributor

You should change the base branch to 4.2

@lyrixx
Copy link
Member Author

lyrixx commented Feb 28, 2019

Oups, closing in favor of #30410

@lyrixx lyrixx closed this Feb 28, 2019
@lyrixx lyrixx deleted the logger-reset branch March 5, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants