Skip Glob brace test when GLOB_BRACE is unavailable #30839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
936681b to
ce38fe3
Compare
fabpot
reviewed
Apr 3, 2019
| @@ -339,6 +339,10 @@ public function testInWithNonDirectoryGlob() | |||
|
|
|||
| public function testInWithGlobBrace() | |||
| { | |||
| if (!\defined('GLOB_BRACE')) { | |||
There was a problem hiding this comment.
Should we also add such a test in the code to alert the developer of the issue?
There was a problem hiding this comment.
I'm not sure we can reliably implement this without a glob parser. We already have a glob parser, but not for this purpose (see Glob::toRegex())
There was a problem hiding this comment.
Fyi, Zend has implemented a fallback in it's stdlib: https://github.com/zendframework/zend-stdlib/blob/master/src/Glob.php#L89-L168
nicolas-grekas
approved these changes
Apr 3, 2019
fabpot
approved these changes
Apr 3, 2019
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2019
…terj) This PR was merged into the 3.4 branch. Discussion ---------- Skip Glob brace test when GLOB_BRACE is unavailable | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | n/a From [PHP.net](https://www.php.net/glob): > Note: The GLOB_BRACE flag is not available on some non GNU systems, like Solaris. This means running the testsuite in e.g. a php-alpine container fails atm. This test should be skipped in these environments. Commits ------- ce38fe3 Skip Glob brace test when GLOB_BRACE is unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PHP.net:
This means running the testsuite in e.g. a php-alpine container fails atm. This test should be skipped in these environments.