[Serializer] provide new ObjectPropertyListExtractorInterface #30904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Apr 6, 2019
src/Symfony/Component/Serializer/Extractor/ObjectPropertyListExtractor.php
Outdated
Show resolved
Hide resolved
joelwurtz
reviewed
Apr 6, 2019
src/Symfony/Component/Serializer/Tests/Extractor/ObjectPropertyListExtractorTest.php
Show resolved
Hide resolved
76c748c to
a146024
Compare
a146024 to
997270f
Compare
16 tasks
fabpot
approved these changes
Apr 6, 2019
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…terface (dmaicher) This PR was merged into the 4.3-dev branch. Discussion ---------- [Serializer] provide new ObjectPropertyListExtractorInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | related to #30818 | License | MIT | Doc PR | - EUFOSSA Hackathon As discussed with @joelwurtz this adds a new `ObjectPropertyListExtractorInterface` and a default implementation. See #30818 > A new interface will be provided ObjectPropertyListExtractorInterface (name can change), that allow getting attributes based on an object. A default implementation will be provided that use the PropertyListExtractorInterface and a class resolver, as the latter one only rely on class name, it may be important to have this distinction (this will allow features that rely on a specific value of the object to get the current property list, like exclusion policy) Commits ------- 997270f [Serializer] provide new ObjectPropertyListExtractorInterface
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…tExtractorInterface (dmaicher) This PR was merged into the 4.3-dev branch. Discussion ---------- [Serializer] add return type hints for ObjectPropertyListExtractorInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | License | MIT | Doc PR | - @nicolas-grekas as just discussed here the type-hint + phpdoc cleanup as follow-up for #30904 😉 cc @joelwurtz Commits ------- 7628972 [Serializer] add return type hints for ObjectPropertyListExtractorInterface
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
…lwurtz) This PR was merged into the 4.3-dev branch. Discussion ---------- [Serializer] Experimental for ObjectListExtractor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30904 | License | MIT | Doc PR | - Related to #30818 I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3 Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance. Commits ------- b0cdf45 Set object list extractor as expiremental, and use final for default implementation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EUFOSSA Hackathon
As discussed with @joelwurtz this adds a new
ObjectPropertyListExtractorInterfaceand a default implementation.See #30818