[Form] Improve invalid messages for form types #30931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhamon
reviewed
Apr 6, 2019
src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
Outdated
Show resolved
Hide resolved
HeahDude
reviewed
Apr 6, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php
Outdated
Show resolved
Hide resolved
HeahDude
approved these changes
Apr 6, 2019
OskarStark
reviewed
Apr 6, 2019
2d027fd to
fa4228b
Compare
sstok
approved these changes
Apr 7, 2019
|
The build fails, but I'm unable to reproduce this locally :-\ Can anyone help me there? |
xabbuh
reviewed
May 3, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
|
@xabbuh Do you a plan to finish this PR? |
|
@xabbuh Friendly ping :) |
d693fe8 to
200008f
Compare
xabbuh
approved these changes
Jul 8, 2020
200008f to
d2f0e4f
Compare
ogizanagi
approved these changes
Jul 9, 2020
src/Symfony/Component/Form/Resources/translations/validators.en.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Resources/translations/validators.en.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Resources/translations/validators.en.xlf
Outdated
Show resolved
Hide resolved
|
Thank you @xabbuh for taking care of this 👍 |
bfed611 to
0137ee1
Compare
0137ee1 to
8728927
Compare
fabpot
approved these changes
Jul 10, 2020
|
Thank you Bernhard. |
|
And thank you @hiddewie for doing the initial work! |
Merged
fabpot
added a commit
that referenced
this pull request
Oct 20, 2020
This PR was squashed before being merged into the 5.x branch. Discussion ---------- [Form] Add missing invalid_message translations | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Some invalid messages were missed in #30931 (probably because of the old age of that PR). This PR adds all missing translation keys and a missing invalid message for the new WeekType. I've also added the dutch translations (might be up for improvement, but it's a start). We should probably initiate another community initiative to translate these new messages (only a couple languages include the new invalid messages yet). Commits ------- 86c78b6 Added dutch translations for new invalid messages 301f0aa Added missing invalid messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request is a continuation of #27142.
Changes done here: