Skip to content

[Form] Add missing invalid_message translations #38617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 18, 2020

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Some invalid messages were missed in #30931 (probably because of the old age of that PR). This PR adds all missing translation keys and a missing invalid message for the new WeekType.

I've also added the dutch translations (might be up for improvement, but it's a start). We should probably initiate another community initiative to translate these new messages (only a couple languages include the new invalid messages yet).

@wouterj wouterj force-pushed the pull-30931/missing-translations branch from 4ddb312 to 86c78b6 Compare October 19, 2020 13:07
@fabpot
Copy link
Member

fabpot commented Oct 20, 2020

Thank you @wouterj.

@fabpot fabpot merged commit 2b1190f into symfony:5.x Oct 20, 2020
@wouterj wouterj deleted the pull-30931/missing-translations branch October 20, 2020 06:15
@fabpot fabpot mentioned this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants