[Security] Fix argon2 availability checks #31014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Apr 8, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes (bug not released yet) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
2895fe7 to
38d9cc0
Compare
dunglas
approved these changes
Apr 8, 2019
73c3e25 to
d905b60
Compare
teohhanhui
suggested changes
Apr 8, 2019
| /** | ||
| * @internal | ||
| */ | ||
| public static function isDefaultSodiumAlgorithm() |
There was a problem hiding this comment.
Suggested change
| public static function isDefaultSodiumAlgorithm() | |
| public static function isDefaultSodiumAlgorithm(): bool |
fabpot
approved these changes
Apr 8, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Apr 8, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Security] Fix argon2 availability checks | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes (bug not released yet) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- dc95a6f [Security] Fix argon2 availability checks
|
see #31016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.