[FrameworkBundle] [Validator] Legacy Translator Checking #31154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snebes
commented
Apr 18, 2019
| @@ -19,7 +19,8 @@ | |||
| "php": "^7.1.3", | |||
| "symfony/contracts": "^1.0.2", | |||
| "symfony/polyfill-ctype": "~1.8", | |||
| "symfony/polyfill-mbstring": "~1.0" | |||
| "symfony/polyfill-mbstring": "~1.0", | |||
| "symfony/translation": "~4.2" | |||
There was a problem hiding this comment.
I moved this into the require section since LegacyTranslatorProxy includes a reference still to the old interface.
|
Thanks, but I don't understand why all these changes. This reintroduces the bug that is fixed by #31108 I feel like the only needed change is moving translation to the require section, isn't it? |
|
see #31156 for an easier alternative solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the recent bug that was introduced in 4.2.7 with regard to the old TranslatorInterface being passed to the LegacyTranslatorProxy decorator, which isn't compatible.
ping @nicolas-grekas since you were looking for this