Skip to content

[Validator] Translation should be required to make LegacyTranslationProxy work #31155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Validator] Translation should be required to make LegacyTranslationProxy work #31155

wants to merge 1 commit into from

Conversation

Simperfit
Copy link
Contributor

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31152
License MIT
Doc PR none

Alternative to #31154, I thinks it's enough to just move the translation to required.

@xabbuh
Copy link
Member

xabbuh commented Apr 18, 2019

I don't think we should make the Translation component a hard requirement (see #31156 for an alternative solution).

@xabbuh xabbuh added this to the 4.2 milestone Apr 18, 2019
@Simperfit
Copy link
Contributor Author

Closing as #31155 (comment) the alternative is better.

@Simperfit Simperfit closed this Apr 18, 2019
@Simperfit Simperfit deleted the bugfix/translation-should-be-required branch April 18, 2019 06:38
@rmikalkenas rmikalkenas mentioned this pull request Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Simperfit @xabbuh @carsonbot