[FrameworkBundle] Add debug:autoconfigure command #31183

Simperfit · 2019-04-19T12:06:25Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#26295
License	MIT
Doc PR	todo

SEE for a complete output and more insight #28730

As far as I'm concerned, i've seen @ro0NL's comments on the PR, I think this is ready and working, we can tweak it, but letting the work from @aaa2000 being dead it not the right call IMHO. This is the the raw commit rebased with master and pushed.

OskarStark · 2019-04-20T09:59:35Z

Please use short array syntax 😊

Simperfit · 2019-04-25T19:47:44Z

cc @chalasr

Simperfit · 2019-04-26T07:01:49Z

AppVeyor failure seems not related

Simperfit · 2019-07-19T07:15:57Z

cc @ro0NL @chalasr what can we do about this ? Do we refator the whole thing or just let this work die ?

ro0NL

im still 👍 for debug:autoconfiguration

ro0NL · 2019-07-19T08:08:03Z

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php

+    /**
+     * @return ContainerBuilder
+     */
+    private function getContainerBuilder()


is the version from ContainerDebugCommand::getContainerBuilder() blocking for this implementation? extending from ContainerDebugCommand gives us things for free

ro0NL · 2019-07-19T08:09:52Z

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php

+    {
+        $tagContainerBuilder = new ContainerBuilder();
+        foreach ($tagContainerBuilder->getServiceIds() as $serviceId) {
+            $tagContainerBuilder->removeDefinition($serviceId);


isnt $tagContainerBuilder empty already 🤔

I think it's to make sure. And we could refactor it to be save empty and clone it on each call, no ?

ro0NL · 2019-07-19T08:10:59Z

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php

+        $tagContainerBuilder->addDefinitions([$autoconfiguredInstanceofItem]);
+
+        $dumper = new YamlDumper($tagContainerBuilder);
+        preg_match('/calls\:\n((?: +- .+\n)+)/', $dumper->dump(), $matches);


no big fan of this approach, i'd opt for passing e.g. getMethodCalls() and render plain text as needed. Eventually could be inlined in execute()

ro0NL · 2019-07-19T08:11:25Z

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php

+    private function dumpTagAttribute(array $tagAttribute)
+    {
+        $cloner = new VarCloner();
+        $cliDumper = new CliDumper(null, null, AbstractDumper::DUMP_LIGHT_ARRAY);


#28898 is meant for this :)

maxhelias

I was wondering if this kind of command existed, now i have the answer.

I'm totally 👍 for this feature.

I have some question

maxhelias · 2019-08-12T12:14:38Z

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php

+    {
+        $tagContainerBuilder = new ContainerBuilder();
+        foreach ($tagContainerBuilder->getServiceIds() as $serviceId) {
+            $tagContainerBuilder->removeDefinition($serviceId);


I think it's to make sure. And we could refactor it to be save empty and clone it on each call, no ?

maxhelias · 2019-08-12T12:20:00Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -376,7 +376,9 @@ public function load(array $configs, ContainerBuilder $container)
        $container->registerForAutoconfiguration(LocaleAwareInterface::class)
            ->addTag('kernel.locale_aware');
        $container->registerForAutoconfiguration(ResetInterface::class)
-            ->addTag('kernel.reset', ['method' => 'reset']);
+            ->addTag('kernel.reset', ['method' => 'reset'])
+            ->addTag('kernel.reset2', ['method' => 'reset2'])


Would not it be a forgotten ? It seems strange to me

Simperfit · 2019-08-13T13:50:40Z

will try to fix this tomorrow.

maxhelias · 2019-08-13T14:00:09Z

Or maybe we can do like for #32584, add a option like --auto ?

Close symfony#26295

nicolas-grekas · 2019-09-29T12:09:35Z

I checked out the PR and here are two things that should be improved to me:

the output should be way more compact
the getContainerBuilder() method in the command always compiles the container. Since this is a slow process, we'd better read from the dumped XML container (then, the command could extend from ContainerDebugCommand as does DebugAutowiringCommand btw). This means we first need to dump autoconfigured types in the XML since they're not right now.

@Simperfit still available to work on this? Otherwise don't hesitate to call for help.

Simperfit · 2019-10-07T07:50:40Z

@nicolas-grekas Thanks for the review, ill look into it this week.

nicolas-grekas · 2019-12-12T19:24:20Z

Anyone willing to take over this one?

atailouloute · 2019-12-18T20:00:06Z

@nicolas-grekas I can take over this if no one did.

nicolas-grekas · 2019-12-18T21:01:25Z

Sure, please do!

atailouloute · 2019-12-18T21:08:35Z

Should I create a new PR starting from this branch ? I don't think I have write access to Simperfit's repo

nicolas-grekas · 2019-12-18T21:17:33Z

Please create another PR.

chalasr · 2019-12-18T22:56:25Z

Closing in favor of #35033.

carsonbot added the Status: Needs Review label Apr 19, 2019

Simperfit changed the title ~~Add debug autoconfigure command~~ [FrameworkBundle] Add debug autoconfigure command Apr 19, 2019

nicolas-grekas added this to the next milestone Apr 19, 2019

Simperfit force-pushed the feature/add-debug-autoconfigue-command branch from 4057f66 to f2dec47 Compare April 21, 2019 07:25

Simperfit marked this pull request as ready for review April 21, 2019 07:42

Simperfit force-pushed the feature/add-debug-autoconfigue-command branch 2 times, most recently from d81ee6c to 4d7e67f Compare April 21, 2019 15:03

ro0NL reviewed Jul 19, 2019

View reviewed changes

maxhelias reviewed Aug 12, 2019

View reviewed changes

nicolas-grekas changed the base branch from master to 4.4 September 29, 2019 11:31

nicolas-grekas changed the title ~~[FrameworkBundle] Add debug autoconfigure command~~ [FrameworkBundle] Add debug:autoconfigure command Sep 29, 2019

[FrameworkBundle] Add debug:autoconfigure command

09bb892

Close symfony#26295

nicolas-grekas force-pushed the feature/add-debug-autoconfigue-command branch from 4d7e67f to 09bb892 Compare September 29, 2019 12:04

nicolas-grekas added Status: Needs Work Feature and removed Status: Needs Review labels Sep 29, 2019

atailouloute mentioned this pull request Dec 18, 2019

[WIP] [FrameworkBundle] Add debug:autoconfigure command #35033

Closed

chalasr closed this Dec 18, 2019

nicolas-grekas modified the milestones: next, 5.1 May 4, 2020

Uh oh!

[FrameworkBundle] Add debug:autoconfigure command #31183

[FrameworkBundle] Add debug:autoconfigure command #31183

Uh oh!

Conversation

Simperfit commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OskarStark commented Apr 20, 2019

Uh oh!

Simperfit commented Apr 25, 2019

Uh oh!

Simperfit commented Apr 26, 2019

Uh oh!

Simperfit commented Jul 19, 2019

Uh oh!

ro0NL left a comment

Choose a reason for hiding this comment

Uh oh!

ro0NL Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ro0NL Jul 19, 2019

Choose a reason for hiding this comment

Uh oh!

maxhelias Aug 12, 2019

Choose a reason for hiding this comment

Uh oh!

ro0NL Jul 19, 2019

Choose a reason for hiding this comment

Uh oh!

ro0NL Jul 19, 2019

Choose a reason for hiding this comment

Uh oh!

maxhelias left a comment

Choose a reason for hiding this comment

Uh oh!

maxhelias Aug 12, 2019

Choose a reason for hiding this comment

Uh oh!

maxhelias Aug 12, 2019

Choose a reason for hiding this comment

Uh oh!

Simperfit commented Aug 13, 2019

Uh oh!

maxhelias commented Aug 13, 2019

Uh oh!

nicolas-grekas commented Sep 29, 2019

Uh oh!

Simperfit commented Oct 7, 2019

Uh oh!

nicolas-grekas commented Dec 12, 2019

Uh oh!

atailouloute commented Dec 18, 2019

Uh oh!

nicolas-grekas commented Dec 18, 2019

Uh oh!

atailouloute commented Dec 18, 2019

Uh oh!

nicolas-grekas commented Dec 18, 2019

Uh oh!

chalasr commented Dec 18, 2019

Uh oh!

Uh oh!

Simperfit commented Apr 19, 2019 •

edited

Loading

ro0NL Jul 19, 2019 •

edited

Loading