[Messenger] Proposal: Alternative for the Stack #31185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function handle(Envelope $envelope) : Envelope | ||
| { | ||
| return $this->currentMiddleware->handle($envelope, $this->nextHandler); |
There was a problem hiding this comment.
this is what the current code avoids: this method now becomes a mandatory indirection point between all middleware frames.
|
There is another alternative: stop passing $next or $stack as argument to handle() and turn middleware into dispatcher decorators: interface MiddlewareInterface extends MessageBusInterface
{
/** @return static */
public function withNextBus(MessageBusInterface $next): MiddlewareInterface;
}then, a middleware would do: |
|
I think this would be harder to understand here |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2019
…are stack (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] ease testing and allow forking the middleware stack | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31179 | License | MIT | Doc PR | - A less radical alternative than #31185 that preserves laziness and addresses the linked issue. Commits ------- 3bdf4b0 [Messenger] ease testing and allow forking the middleware stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft proposal for replacing the StackInterface
Follow up on #31179