[Messenger] ease testing and allow forking the middleware stack #31204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b38a927 to
3bdf4b0
Compare
weaverryan
approved these changes
Apr 23, 2019
weaverryan
reviewed
Apr 23, 2019
| return $this->iterator = null; | ||
| } | ||
|
|
||
| return $this->stack[] = $this->iterator->current(); |
There was a problem hiding this comment.
I had to stare at this for a minute. When you clone the StackMiddleware, each clone will still maintain this same, one instance of this MiddlewareStack, but will now maintain their own StackMiddleware.offset property (so, that property will move independently). The first StackMiddleware that uses an item from the iterator will use it, but store it on the stack so that it's available when the other StackMiddleware asks for that same $offset.
danizord
reviewed
Apr 23, 2019
| /** | ||
| * @internal | ||
| */ | ||
| class MiddlewareStack |
There was a problem hiding this comment.
Can't you simply drop the iterator, store middleware as array in StackMiddleware and advance the pointer manually?
There was a problem hiding this comment.
That would defeat laziness, which is a desired property.
chalasr
approved these changes
Apr 25, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2019
…are stack (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] ease testing and allow forking the middleware stack | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31179 | License | MIT | Doc PR | - A less radical alternative than #31185 that preserves laziness and addresses the linked issue. Commits ------- 3bdf4b0 [Messenger] ease testing and allow forking the middleware stack
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A less radical alternative than #31185 that preserves laziness and addresses the linked issue.