[Validator] Allow intl timezones #31292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Apr 27, 2019
src/Symfony/Component/Validator/Tests/Constraints/TimezoneValidatorTest.php
Show resolved
Hide resolved
This was referenced Apr 29, 2019
weaverryan
pushed a commit
to weaverryan/symfony
that referenced
this pull request
Apr 30, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] Extra timezone tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This PR adds some extra tests, to cover the timezone domain. Ideally to go before symfony#31292 :) Commits ------- 4f2bba7 [Validator] Extra timezone tests
fabpot
added a commit
that referenced
this pull request
Apr 30, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Intl] Extra timezone tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (including intl-data group) | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Guarantees timezone data integrity. Ideally to go before #31292 :) Commits ------- a3cac2b [Intl] Extra timezone tests
fabpot
approved these changes
May 1, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 1, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] Allow intl timezones | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | ref #28836 | License | MIT | Doc PR | symfony/symfony-docs#11502 This PR considers the ICU timezones (#28831) as valid, as well as the PHP ones. Both can be used in `DateTimeZone`, but expired timezones cannot be used with `IntlTimeZone`. The `intlCompatibility` option ensures compatibility between both. Practically this allows for both `UTC` and `Etc/UTC`, where the latter should be preferred. I.e. currently `Etc/UTC` is considered an invalid timezone ... which it's not. Commits ------- 7294b59 [Validator] Allow intl timezones
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR considers the ICU timezones (#28831) as valid, as well as the PHP ones.
Both can be used in
DateTimeZone, but expired timezones cannot be used withIntlTimeZone. TheintlCompatibilityoption ensures compatibility between both.Practically this allows for both
UTCandEtc/UTC, where the latter should be preferred. I.e. currentlyEtc/UTCis considered an invalid timezone ... which it's not.