[DI] deprecates tag !tagged in favor of !tagged_iterator #31321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit into symfony:4.4 from jschaedl:di-tagged_iterator

Jun 9, 2019

Contributor

jschaedl commented Apr 29, 2019 •

edited

Loading

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#31289
License	MIT
Doc PR	tbd.

Todo

fix tests

carsonbot added Status: Needs Review DependencyInjection Deprecation labels

jschaedl changed the title ~~[DI] deprecates tag tagged in favor of tagged_iterator~~ [DI] deprecates tag !tagged in favor of !tagged_iterator

OskarStark approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

jschaedl force-pushed the di-tagged_iterator branch from d56bc8b to fad0d11 Compare

April 30, 2019 09:14

nicolas-grekas added this to the next milestone

ro0NL reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php Outdated Show resolved Hide resolved

jschaedl force-pushed the di-tagged_iterator branch from b5bbb98 to 6cd7c47 Compare

April 30, 2019 10:37

ro0NL reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd Show resolved Hide resolved

jschaedl force-pushed the di-tagged_iterator branch 3 times, most recently from 44c3096 to 6ebb340 Compare

May 1, 2019 18:52

ro0NL approved these changes

View reviewed changes

UPGRADE-4.4.md Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

UPGRADE-5.0.md Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

UPGRADE-5.0.md Outdated Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php Outdated Show resolved Hide resolved

jschaedl force-pushed the di-tagged_iterator branch from 5398832 to 77bf619 Compare

May 5, 2019 20:23

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php Outdated Show resolved Hide resolved

jschaedl commented

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved

Contributor Author

jschaedl commented May 12, 2019

The TravisCi failure seems strange to me. I added the new argument type tagged_iterator to the services-1.0.xsd (See: https://github.com/symfony/symfony/pull/31321/files#diff-0e535437d820c04db5c34dcc4210e3da) and the XmlParsingException shouldn't occur. Maybe a caching issue?

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml

@@ @@ -60,7 +60,7 @@ @@
                       <!-- transports -->
                       <service id="messenger.transport_factory" class="Symfony\Component\Messenger\Transport\TransportFactory">
-                          <argument type="tagged" tag="messenger.transport_factory" />
+                          <argument type="tagged_iterator" tag="messenger.transport_factory" />

Member

nicolas-grekas May 22, 2019

this means FWB now needs DI v4.4
this is why tests fail: the composer.json needs an update

Member

nicolas-grekas commented May 22, 2019

(rebase needed also)

jschaedl force-pushed the di-tagged_iterator branch from 14a94a3 to 79099a0 Compare

June 1, 2019 08:55

jschaedl changed the base branch from master to 4.4

June 1, 2019 08:55

jschaedl force-pushed the di-tagged_iterator branch from 79099a0 to 116da00 Compare

June 1, 2019 08:58

Member

nicolas-grekas commented Jun 3, 2019

The failing job is checking out branch 4.4 and loading dependencies with your patch applied.
This highlights that FrameworkBundle 4.4 is currently not compatible with DI 5.0 in your PR.
That's what needs to be fixed.

jschaedl force-pushed the di-tagged_iterator branch from 00acdff to 5597bd7 Compare

June 3, 2019 21:17

xabbuh approved these changes

View reviewed changes

Member

xabbuh left a comment

maybe we should keep tests for the legacy behaviour though to make sure that we do not accidentally break it


          [DI] deprecates tag !tagged in favor of !tagged_iterator

ab8fb18

nicolas-grekas force-pushed the di-tagged_iterator branch from 9bc7b56 to ab8fb18 Compare

June 9, 2019 16:06

Member

nicolas-grekas commented Jun 9, 2019

Thank you @jschaedl.

nicolas-grekas merged commit ab8fb18 into symfony:4.4

nicolas-grekas mentioned this pull request

Add docs for: [DI] deprecates tag !tagged in favor of !tagged_iterator symfony/symfony-docs#11706

Closed

nicolas-grekas added a commit that referenced this pull request


          feature #31321 [DI] deprecates tag !tagged in favor of !tagged_iterat…

7f39f36

…or (jschaedl)

This PR was squashed before being merged into the 4.4 branch (closes #31321).

Discussion
----------

[DI] deprecates tag !tagged in favor of !tagged_iterator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #31289
| License       | MIT
| Doc PR        | tbd.

### Todo

- [x] fix tests

Commits
-------

ab8fb18 [DI] deprecates tag !tagged in favor of !tagged_iterator

Member

nicolas-grekas commented Jun 9, 2019 •

edited

Loading

@jschaedl would you mind sending a PR to remove the deprecated codes on master?

Contributor Author

jschaedl commented Jun 9, 2019

@nicolas-grekas Sure, I'm happy to do that :-)

jschaedl mentioned this pull request

[DI] remove deprecated tag !tagged in favor of !tagged_iterator #31967

Merged

nicolas-grekas added a commit that referenced this pull request


          minor #31967 [DI] remove deprecated tag !tagged in favor of !tagged_i…

e8c2a1b

…terator (jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove deprecated tag !tagged in favor of !tagged_iterator

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | related ticket #31289   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#tbd <!-- required for new features -->

This PR removes tag `tagged` which was deprecated in #31321

Commits
-------

9978184 [DI] removed tagged

jschaedl mentioned this pull request

[DI] Add deprecation info for !tagged symfony/symfony-docs#11708

Merged

OskarStark added a commit to symfony/symfony-docs that referenced this pull request


          minor #11708 [DI] Add deprecation info for !tagged (jschaedl)

dea6fd0

This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes #11708).

Discussion
----------

[DI] Add deprecation info for !tagged

Fixes #11706

Feature PR: symfony/symfony#31321

Commits
-------

65263e1 [DI] Add deprecation info for !tagged

nicolas-grekas modified the milestones: next, 4.4

This was referenced Nov 12, 2019

Release v4.4.0-BETA1 #34338

Merged

Release v5.0.0-BETA1 #34339

Merged

jschaedl deleted the di-tagged_iterator branch

February 23, 2020 08:01

maxhelias mentioned this pull request

[DI] replace tagged by tagged_iterator symfony/symfony-docs#14337

Merged

GSadee mentioned this pull request

Rename tag tagged to tagged_iterator Sylius/Sylius#14193

Merged

Zales0123 added a commit to Sylius/Sylius that referenced this pull request


          refactor #14193 Rename tag tagged to tagged_iterator (GSadee)

f1d6f14

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12 <!-- see the comment below -->          |
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no|
| Related tickets | |
| License         | MIT                                                          |

As `tagged` has been deprecated in Symfony 4.4: symfony/symfony#31321
<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

8e9eb8c Rename tag tagged to tagged_iterator

Zales0123 added a commit to Sylius/SyliusApiBundle that referenced this pull request


          refactor #14193 Rename tag tagged to tagged_iterator (GSadee)

99c7313

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12 <!-- see the comment below -->          |
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no|
| Related tickets | |
| License         | MIT                                                          |

As `tagged` has been deprecated in Symfony 4.4: symfony/symfony#31321
<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

8e9eb8cffeed5d19e4cdb60409faca4d4b4fd5cd Rename tag tagged to tagged_iterator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DependencyInjection Deprecation Status: Reviewed