[Intl] Cleanup #31366
[Intl] Cleanup #31366
Conversation
| 'XSU' => true, // Sucre | ||
| 'XDR' => true, // Special Drawing Rights | ||
| 'XTS' => true, // Testing Currency Code | ||
| 'XXX' => true, // Unknown Currency |
There was a problem hiding this comment.
Not sure what's the point of this. Constants were self explanatory, now we need a comment.
There was a problem hiding this comment.
maintaining the consts is an extra task, not worth it IMHO. i didnt follow it for languages also.
feel free to ignore :) but it reduces noise and makes adding entries more straightforward (the consts are only used here; it's not real API needed)
| @@ -13,7 +13,6 @@ | |||
|
|
|||
| use Symfony\Component\Intl\Data\Bundle\Reader\BundleEntryReaderInterface; | |||
| use Symfony\Component\Intl\Exception\MissingResourceException; | |||
| use Symfony\Component\Intl\Locale; | |||
There was a problem hiding this comment.
Erm... are you sure about this?
There was a problem hiding this comment.
yep :)
updated as such below
it's a tiny improvement, but worth clarifying IMHO to rely on the root \Locale (either the real one, or the Intl\Locale\Locale stub.
Intl\Locale extends from \Locale and doesnt own the default, only the default fallback.
This internal, first citizent, Intl\Locale is super confusing, and is really a LocaleFallback util
|
@jakzal Are you ok to merge this one? |
|
the sole purpose of the PR is to reduce merge conflicts, if it doesnt matter much we can close (but in master / #31365 we take a different apprach, as im really skeptical about maintaining the lists of consts :D) |
|
Thank you @ro0NL. |
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Cleanup | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> cleanup of #31365 for 3.4 + some other stuff to keep in sync across branches Commits ------- 70a941e [Intl] Cleanup
cleanup of #31365 for 3.4 + some other stuff to keep in sync across branches