[Validator] Allow to use property paths to get limits in range constraint #31511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogizanagi Done. |
|
Rebased on |
|
Failure in |
xabbuh
reviewed
Jun 18, 2019
ro0NL
reviewed
Jun 18, 2019
| } | ||
|
|
||
| if ((isset($options['minPropertyPath']) || isset($options['maxPropertyPath'])) && !class_exists(PropertyAccess::class)) { | ||
| throw new ConstraintDefinitionException(sprintf('The "%s" constraint requires the Symfony PropertyAccess component to use the "minPropertyPath" or "maxPropertyPath" option.', \get_class($this))); |
There was a problem hiding this comment.
should be Symfony\Component\Validator\Exception\LogicException
There was a problem hiding this comment.
fabpot
approved these changes
Jul 8, 2019
|
Thank you @Lctrs. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…in range constraint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes #31511). Discussion ---------- [Validator] Allow to use property paths to get limits in range constraint | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Part of #31503 | License | MIT | Doc PR | symfony/symfony-docs#11793 Similar as #22576, but for the `Range` constraint. Commits ------- 2b50990 [Validator] Allow to use property paths to get limits in range constraint
fabpot
added a commit
that referenced
this pull request
Jul 9, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Fix Changelog for #31511 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 9d72505 [Validator] Fix Changelog for #31511
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 10, 2019
…traint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes #11793). Discussion ---------- Document the new property path options of the Range constraint Related PR : symfony/symfony#31511 Commits ------- 08e724c Document the new property path options of the Range constraint
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2019
* 4.4: (53 commits) Fix Twig 1.x compatibility Deprecating templateExists method [Translator] Improve farsi(persian) translations for Form [Validator] Fix Changelog for #31511 [Lock][Console] bump lock requirement in console [Lock] minor: add missing alias for PersistenStoreInterface Improve fa translations Dynamic bundle assets [Lock] rename and deprecate Factory into LockFactory [Debug] Restoring back the state of the Debug component (1st step) Spell "triggering" properly [Lock] Fix tests Added tests to cover the possibility of having scalars as services. fixed CS [Lock] Split \"StoreInterface\" into multiple interfaces with less responsability [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit [Validator] Allow to use property paths to get limits in range constraint Fix missing deprecations fixed tests on old PHP versions [FrameworkBundle] Inform the user when save_path will be ignored ...
This was referenced Nov 12, 2019
Merged
Merged
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
* 4.4: (53 commits) Fix Twig 1.x compatibility Deprecating templateExists method [Translator] Improve farsi(persian) translations for Form [Validator] Fix Changelog for symfony#31511 [Lock][Console] bump lock requirement in console [Lock] minor: add missing alias for PersistenStoreInterface Improve fa translations Dynamic bundle assets [Lock] rename and deprecate Factory into LockFactory [Debug] Restoring back the state of the Debug component (1st step) Spell "triggering" properly [Lock] Fix tests Added tests to cover the possibility of having scalars as services. fixed CS [Lock] Split \"StoreInterface\" into multiple interfaces with less responsability [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit [Validator] Allow to use property paths to get limits in range constraint Fix missing deprecations fixed tests on old PHP versions [FrameworkBundle] Inform the user when save_path will be ignored ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar as #22576, but for the
Rangeconstraint.