[SECURITY] AbstractAuthenticationListener.php error instead info. Rebase of #28462 #31554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
suggested changes
May 21, 2019
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
Outdated
Show resolved
Hide resolved
berezuev
added a commit
to berezuev/symfony
that referenced
this pull request
May 21, 2019
|
In #28462 (comment), @curry684 suggest to always use |
|
IIUC, it should always be an |
|
@fabpot I've done this change and set PR's destination to 4.4 branch. |
fabpot
approved these changes
Jul 8, 2019
|
Thank you @berezuev. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…stead info. Rebase of #28462 (berezuev) This PR was merged into the 4.4 branch. Discussion ---------- [SECURITY] AbstractAuthenticationListener.php error instead info. Rebase of #28462 | Q | A | ------------- | --- | Branch? | 4.4 | -- | -- | Bug fix? | yes | New feature? | no | BC breaks? | no I think | Deprecations? | no | Tests pass? | yes | Fixed tickets | ... | License | MIT Rebase of #28462. Origin description: > ``` > [2018-09-13 20:43:38] security.INFO: Authentication request failed. {"exception":"[object] (Symfony\\Component\\Security\\Core\\Exception\\AuthenticationServiceException(code: 0): An exception occurred while executing > ... > Doctrine\\DBAL\\Driver\\PDOException(code: 42S22): SQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.phone' in 'field list' at > ``` > > Definitely I think this is NOT info, but error. > And since it's info, it's not logged in production because of `fingers_crossed` with `action_level: error` - so to actually see the real error behind `Authentication request could not be processed due to a system problem.` I had to debug on production. Very bad practice IMHO. Commits ------- 867eb78 [SECURITY] AbstractAuthenticationListener.php error instead info. Rebase of #28462
This was referenced Nov 12, 2019
Merged
Merged
|
Change as been reverted in #34957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #28462. Origin description: