[Security] Revert "AbstractAuthenticationListener.php error instead info" #34957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Because the new error() level has a very practical negative effect (all login attempts are going into high priority log handlers, commonly Slack) and there is no easy way to work around this (that I know of), I think we should merge this and revisit how this could be done in a more flexible way. I get why it was done, but our logs are going crazy :)
Note: should be merged into 4.4
…nfo. Rebase of symfony#28462" This reverts commit 867eb78.
94d5cc9 to
9d306f9
Compare
|
Thank you @larzuk91. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2019
…r instead info" (larzuk91) This PR was submitted for the master branch but it was merged into the 4.4 branch instead. Discussion ---------- [Security] Revert "AbstractAuthenticationListener.php error instead info" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34836 | License | MIT This reverts commit 867eb78. After that change, every failed login attempt is logged as an error. It's flooding our errors log channel Commits ------- 9d306f9 [SECURITY] Revert "AbstractAuthenticationListener.php error instead info. Rebase of #28462"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 867eb78.
After that change, every failed login attempt is logged as an error. It's flooding our errors log channel