[HttpClient] display proper error message on TransportException when curl is used #31586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
approved these changes
May 22, 2019
GwendolenLynch
approved these changes
May 22, 2019
Simperfit
approved these changes
May 23, 2019
cb63b12 to
3273109
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2019
…ption when curl is used (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] display proper error message on TransportException when curl is used | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Reported independently by @GawainLynch and @tgalopin: the message of TransportException is currently empty when using CurlHttpClient. This now displays e.g. ``` [Symfony\Component\HttpClient\Exception\TransportException] Couldn't connect to server for http://localhost:8000/index.html ``` Commits ------- 3273109 [HttpClient] display proper error message on TransportException when curl is used
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Sep 29, 2021
…icolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] improve curl error message when possible | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #37666 | License | MIT | Doc PR | - Fix #37666, improves #31586 Commits ------- fac0e66 [HttpClient] improve curl error message when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported independently by @GawainLynch and @tgalopin:
the message of TransportException is currently empty when using CurlHttpClient.
This now displays e.g.