Skip to content

[HttpKernel] Make DebugHandlersListener internal #31732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented May 30, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Required to remove the legacy Event argument type declaration from its configure() method in 5.0.
Unlocks #31689

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't miss UPGRADE files :)

@chalasr chalasr force-pushed the debughandlerlistener-internal branch from c2ce35a to 1a8db29 Compare May 30, 2019 13:23
@chalasr
Copy link
Member Author

chalasr commented May 30, 2019

UPGRADE files updated, thanks

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 1a8db29 into symfony:4.4 May 30, 2019
nicolas-grekas added a commit that referenced this pull request May 30, 2019
…asr)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Make DebugHandlersListener internal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required to remove the legacy `Event` argument type declaration from its `configure()` method in 5.0.
Unlocks #31689

Commits
-------

1a8db29 [HttpKernel] Make DebugHandlersListener internal
@chalasr chalasr deleted the debughandlerlistener-internal branch May 30, 2019 13:27
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants