Skip to content

[FrameworkBundle] add attribute stamps #31764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

[FrameworkBundle] add attribute stamps #31764

merged 1 commit into from
Jun 18, 2019

Conversation

walidboughdiri
Copy link
Contributor

@walidboughdiri walidboughdiri commented May 31, 2019 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@Tobion
Copy link
Contributor

Tobion commented May 31, 2019

It's a new feature that cannot go in 4.3

@walidboughdiri walidboughdiri changed the base branch from 4.3 to 4.4 June 1, 2019 00:58
@walidboughdiri walidboughdiri changed the title add attribute stamps [FrameworkBundle] add attribute stamps Jun 1, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Jun 1, 2019
nicolas-grekas
nicolas-grekas approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor CS comments to fix before merging.

@fabpot
Copy link
Member

fabpot commented Jun 18, 2019

Thank you @walidboughdiri.

@fabpot fabpot mentioned this pull request Jun 18, 2019
Closed
@fabpot fabpot merged commit 8a09579 into symfony:4.4 Jun 18, 2019
fabpot added a commit that referenced this pull request Jun 18, 2019
@fabpot
feature #31764 [FrameworkBundle] add attribute stamps (walidboughdiri)
411ad97 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] add attribute stamps

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | yes<!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

8a09579 remove bc break code
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
@walidboughdiri walidboughdiri deleted the add-attribute-stamps branch October 3, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Ready Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@walidboughdiri @Tobion @fabpot @nicolas-grekas @carsonbot