Skip to content

[FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer #31821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 3, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As part of #21035 and 7169f4d

@Tobion
Copy link
Contributor

Tobion commented Jun 3, 2019

What about #31800 (comment)

@yceruto yceruto force-pushed the add_missing_deprecation branch from f299d13 to 61613d0 Compare June 3, 2019 16:53
@yceruto
Copy link
Member Author

yceruto commented Jun 3, 2019

@Tobion done.

@fabpot
Copy link
Member

fabpot commented Jun 3, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 61613d0 into symfony:4.4 Jun 3, 2019
fabpot added a commit that referenced this pull request Jun 3, 2019
… for PHP templating layer (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As part of #21035 and 7169f4d

Commits
-------

61613d0 Add missing deprecations for PHP templating layer
@yceruto yceruto deleted the add_missing_deprecation branch June 3, 2019 17:20
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants