Removed support for PHP templating everywhere #31800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yceruto Some tests are broken with this PR. |
5f88db9 to
07020d0
Compare
|
Tests are green now. |
Tobion
reviewed
Jun 3, 2019
|
|
||
| public function __construct(Environment $twig = null, EngineInterface $templating = null) | ||
| public function __construct(Environment $twig = null) |
There was a problem hiding this comment.
I feel like twig should not be optional in this class. And when twig is not installed, the TemplateController should be removed from DI.
There was a problem hiding this comment.
I agree, but for DX point of view it's better as is, because you'll get a good error message:
You can not use the TemplateController if the Twig Bundle is not available.
vs
"Too few arguments to function Symfony\Bundle\FrameworkBundle\Controller\TemplateController::__construct(), 0 passed in ...
WDYT?
There was a problem hiding this comment.
I agree it's a little better for DX. But IMO it's not the responsiblity of the Controller do provide that.
We could just catch the instantiation error in
Tobion
reviewed
Jun 3, 2019
src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Jun 3, 2019
src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Jun 3, 2019
Tobion
reviewed
Jun 3, 2019
|
Requires #31821 Status: Needs Work |
|
Rebase unlocked. |
9686ff3 to
116be1f
Compare
116be1f to
d5be373
Compare
|
(Rebased) Status: Needs Review |
Tobion
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Fine for me. https://github.com/symfony/symfony/pull/31800/files#r290086885 can be done in a separate PR.
fabpot
approved these changes
Jun 4, 2019
| if (!$this->container->has('twig')) { | ||
| throw new \LogicException('You can not use the "renderView" method if the Templating Component or the Twig Bundle are not available. Try running "composer require symfony/twig-bundle".'); | ||
| throw new \LogicException('You can not use the "renderView" method if the Twig Bundle are not available. Try running "composer require symfony/twig-bundle".'); |
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jun 4, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Removed support for PHP templating everywhere | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ref: #21035 and 7169f4d **TODO:** Missing deprecations in 4.4 (#31800): - [x] `Symfony\Bundle\FrameworkBundle\Controller\TemplateController` 2nd argument. - [x] `Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheCacheWarmer` class and service. **Labels:** `FrameworkBundle`, `TwigBundle`, `TwigBridge`, `SecurityBundle`, `Form`, `HttpKernel` Friendly ping @fabpot and @dunglas Commits ------- d5be373 Removed support for PHP templating everywhere
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…ion (xabbuh) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] deprecate the framework.templating option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32120 | License | MIT | Doc PR | The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix. Commits ------- ba241ce deprecate the framework.templating option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #21035 and 7169f4d
TODO:
Missing deprecations in 4.4 (#31800):
Symfony\Bundle\FrameworkBundle\Controller\TemplateController2nd argument.Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheCacheWarmerclass and service.Labels:
FrameworkBundle,TwigBundle,TwigBridge,SecurityBundle,Form,HttpKernelFriendly ping @fabpot and @dunglas