[FrameworkBundle] fix FC with HttpKernel v5 #31938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
suggested changes
Jun 7, 2019
Simperfit
approved these changes
Jun 7, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2019
…kas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] fix FC with HttpKernel v5 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This class is deprecated and is thus not enough a reason to conflict with http-kernel v5 Should unlock #31918 Commits ------- 6c109c7 [FrameworkBundle] fix FC with HttpKernel v5
derrabus
added a commit
that referenced
this pull request
Mar 7, 2021
…eControllerNameSubscriber (glensc) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] [4.4]: Fix method name compare in ResolveControllerNameSubscriber | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> The left side to `strtolower` was not actually lowercased, so it would be always `false`. The bug was introduced in 6c109c7 (#31938) <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> Commits ------- 69431a3 Fix method name compare in ResolveControllerNameSubscriber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is deprecated and is thus not enough a reason to conflict with http-kernel v5
Should unlock #31918