[FrameworkBundle] [4.4]: Fix method name compare in ResolveControllerNameSubscriber #40398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The left side to strtolower was not actually lowercased, so it would be always false.
derrabus
approved these changes
Mar 6, 2021
chalasr
approved these changes
Mar 7, 2021
OskarStark
approved these changes
Mar 7, 2021
|
Thank you @glensc. |
Merged
|
This should appear only in 4.4 release, as the patched class is removed in 5.0: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left side to
strtolowerwas not actually lowercased, so it would be alwaysfalse.The bug was introduced in 6c109c7 (#31938)