[FrameworkBundle] deprecate the framework.templating option #32267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go in 4.3 because that's where the deprecation happened. You cannot fix the other deprecations without removing the config. So this is a requirement and serves as explanation. |
|
Please also add the instructions to UPGRADE-4.3.md as pointed out in #32120 |
derrabus
approved these changes
Jun 29, 2019
You are right. I have just checked this on a fresh installation. |
derrabus
approved these changes
Jun 29, 2019
Tobion
approved these changes
Jun 29, 2019
chalasr
approved these changes
Jul 2, 2019
Simperfit
approved these changes
Jul 3, 2019
fabpot
approved these changes
Jul 3, 2019
| @@ -169,8 +169,8 @@ Form | |||
| FrameworkBundle | |||
| --------------- | |||
|
|
|||
| * Remved the `framework.templating` option, use Twig instead. | |||
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…ion (xabbuh) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] deprecate the framework.templating option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32120 | License | MIT | Doc PR | The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix. Commits ------- ba241ce deprecate the framework.templating option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config node has already been removed in the
masterbranch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix.