[PropertyAccess] Adds entries to CHANGELOG and UPGRADE #32269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Jun 28, 2019
8d3086f to
6724352
Compare
OskarStark
reviewed
Jun 30, 2019
UPGRADE-4.4.md
Outdated
| PropertyAccess | ||
| -------------- | ||
|
|
||
| * Deprecated passing `null` as 2nd argument of `PropertyAccessor::createCache()` method (`$defaultLifetime`), pass 0 instead. |
jschaedl
commented
Jul 1, 2019
jschaedl
commented
Jul 1, 2019
|
You could add an entry in UPGRADE-5.0.md as well mentioning the support for |
OskarStark
approved these changes
Jul 3, 2019
fabpot
approved these changes
Jul 3, 2019
641f430 to
c4afbf3
Compare
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…jschaedl) This PR was squashed before being merged into the 4.4 branch (closes #32269). Discussion ---------- [PropertyAccess] Adds entries to CHANGELOG and UPGRADE | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A In PR #32241 I missed to add entries to the CHANGELOG and UPGRADE file. Commits ------- c4afbf3 [PropertyAccess] Adds entries to CHANGELOG and UPGRADE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #32241 I missed to add entries to the CHANGELOG and UPGRADE file.