Skip to content

Remove @experimental annotations #32277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jun 29, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Nothing can be marked as experimental in 4.4.

@fabpot
Copy link
Member Author

fabpot commented Jun 29, 2019

I've also removed the @experimental tag on Contracts. I think it makes sense as the HttpClient component won't be experimental anymore.

@nicolas-grekas
Copy link
Member

For contracts, we may want to do it later, in case we want to release a new "bugfix" version.
👍 otherwise!

@fabpot
Copy link
Member Author

fabpot commented Jun 29, 2019

Contract changes reverted.

@fabpot fabpot force-pushed the experimental-removal branch from 1f31ca6 to 191cb52 Compare June 29, 2019 16:45
@fabpot fabpot merged commit 191cb52 into symfony:4.4 Jun 29, 2019
fabpot added a commit that referenced this pull request Jun 29, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Remove @experimental annotations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Nothing can be marked as experimental in 4.4.

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

191cb52 removed @experimental annotations
fabpot added a commit that referenced this pull request Jul 12, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Remove experimental notice from components

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

@fabpot:
> Nothing can be marked as experimental in 4.4.
>
> #32277

Commits
-------

390c9a6 Remove experimental notice from components
symfony-splitter pushed a commit to symfony/messenger that referenced this pull request Jul 12, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Remove experimental notice from components

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

@fabpot:
> Nothing can be marked as experimental in 4.4.
>
> symfony/symfony#32277

Commits
-------

390c9a67bf Remove experimental notice from components
@fabpot fabpot deleted the experimental-removal branch July 18, 2019 20:17
This was referenced Nov 12, 2019
symfony-splitter pushed a commit to symfony/messenger that referenced this pull request Jan 28, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

Remove experimental notice from components

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

@fabpot:
> Nothing can be marked as experimental in 4.4.
>
> symfony/symfony#32277

Commits
-------

390c9a67bf Remove experimental notice from components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants