Skip to content

Remove experimental notice from components #32478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2019
Merged

Remove experimental notice from components #32478

merged 1 commit into from
Jul 12, 2019

Conversation

teohhanhui
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@fabpot:

Nothing can be marked as experimental in 4.4.

#32277

@teohhanhui teohhanhui requested a review from sroze as a code owner July 10, 2019 09:47
@teohhanhui
Copy link
Contributor Author

Hmm... It seems like the same message is in a few other components as well.

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 11, 2019
@nicolas-grekas
Copy link
Member

@teohhanhui can you please remove them all in this PR?

@teohhanhui teohhanhui changed the title Remove experimental notice of Messenger component Remove experimental notice from components Jul 11, 2019
@teohhanhui
Copy link
Contributor Author

Done.

@fabpot
Copy link
Member

fabpot commented Jul 12, 2019

Thank you @teohhanhui.

@fabpot fabpot merged commit 390c9a6 into symfony:4.4 Jul 12, 2019
fabpot added a commit that referenced this pull request Jul 12, 2019
@fabpot
minor #32478 Remove experimental notice from components (teohhanhui)
c4568d1 
This PR was merged into the 4.4 branch.

Discussion
----------

Remove experimental notice from components

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

@fabpot:
> Nothing can be marked as experimental in 4.4.
>
> #32277

Commits
-------

390c9a6 Remove experimental notice from components
@teohhanhui teohhanhui deleted the patch-3 branch July 12, 2019 13:37
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Tobion Tobion Tobion approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@teohhanhui @nicolas-grekas @fabpot @Tobion @carsonbot