Skip to content

[Lock] remove deprecated Factory for LockFactory #32495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jul 11, 2019

Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR todo

This remove the deprecated Factory and changes the alias in FrameworkBundle.

@Simperfit Simperfit force-pushed the feature/remove-Factory-for-LockFactory branch from af09f0f to eb5d06c Compare July 13, 2019 14:46
@Simperfit Simperfit force-pushed the feature/remove-Factory-for-LockFactory branch from eb5d06c to 8bd805a Compare July 17, 2019 19:15
/**
* @author Jérémy Derussé <jeremy@derusse.com>
*/
class FactoryTest extends TestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted (and renamed into LockFactoryTest)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

@Simperfit
Copy link
Contributor Author

like @stof said, closing in favor of #32555 (this commits has been cherry-picked in the other PR)

@Simperfit Simperfit closed this Jul 18, 2019
@Simperfit Simperfit deleted the feature/remove-Factory-for-LockFactory branch July 18, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants