Fix multiSelect ChoiceQuestion when answers have spaces #32503
Conversation
|
If this is really something we want to do, it should be deprecated before doing so, because it will break existing command that rely on this. |
|
Any bugfix might break someone's behavior. This should apply to the 3.4 branch. And trimming should be disabled conditionally as of #31626 (4.4), we missed this part. |
|
Without the trim on multiple answers, it might break cases where answers don't have spaces but user input have. Exemple : Maybe set all ChoiceQuestion as Trimmable by default on 4.4 for backward compatibility ? |
| /** | ||
| * @dataProvider selectUseCases | ||
| */ | ||
| public function testSelectUseCases($isMiltiSelect, $answers, $expected, $message) |
There was a problem hiding this comment.
typo isMiltiSelect/isMultiSelect
| $validator = $question->getValidator(); | ||
| $actual = $validator($answer); | ||
|
|
||
| $this->assertEquals($actual, $expected, sprintf($message, $answer)); |
|
@IceMaD yes, trimming must stay enabled by default. Can you please rebase against the 3.4 branch and change the PR base branch accordingly? |
|
Thank you @IceMaD. |
…ceMaD) This PR was merged into the 3.4 branch. Discussion ---------- Fix multiSelect ChoiceQuestion when answers have spaces | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32502 | License | MIT | Doc PR | N/A Probleme is explained in the issue Commits ------- 9104ef1 Fix multiSelect ChoiceQuestion when answers have spaces
|
And thank you for contributing to Symfony for the first time. Well done, congratz :) |
Probleme is explained in the issue