[Console] allow answer to be trimmed by adding a flag #31626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39a3bb9 to
3f60320
Compare
|
fabbot failure is a false positive |
3f60320 to
782c2ca
Compare
chalasr
reviewed
May 27, 2019
6cef233 to
de53851
Compare
de53851 to
c355ee0
Compare
|
@chalasr update to 4.4 and review fixed |
apfelbox
reviewed
Jun 4, 2019
92091ff to
8f182d8
Compare
|
AppVeyor failure is unrelated, PR rebased |
fabpot
approved these changes
Jul 8, 2019
| 4.4.0 | ||
| ----- | ||
|
|
||
| * added `Question::setTrimmable` default to true to allow the answer to be trimmed or not |
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…(Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Console] allow answer to be trimmed by adding a flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#11603 <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> According to #23210 (comment) we add a new flag in the `Question` class to be able to not trim the answer. Commits ------- 8f182d8 [Console] allow answer to be trimmed by adding a flag
This was referenced Jul 24, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #23210 (comment) we add a new flag in the
Questionclass to be able to not trim the answer.