[Messenger] pass transport name to factory #32567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 17, 2019
fabpot
approved these changes
Jul 19, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] pass transport name to factory | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32526 | License | MIT | Doc PR | It's technically a new feature but so tiny I'd be happy to have it in 4.3 Commits ------- 59926c8 [Messenger] pass transport name to factory
Tobion
added a commit
that referenced
this pull request
Jul 19, 2019
…tion (Tobion) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] fix transport_name option not passing validation | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32567 | License | MIT | Doc PR | the doctrine transport connection validates the options and complains about this option, so we remove it before. the other transports will probably add the validation as well: #32575 the purpose of the option is for custom transport factories anyway. Commits ------- 48408e3 [Messenger] fix transport_name option not passing validation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's technically a new feature but so tiny I'd be happy to have it in 4.3