[Form][Validator] Generate accept attribute with file constraint and mime types option #32587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Jul 18, 2019
src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Jul 21, 2019
src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Jul 22, 2019
src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorTypeGuesserTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorTypeGuesserTest.php
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Jul 23, 2019
src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorTypeGuesserTest.php
Outdated
Show resolved
Hide resolved
…mime types option
92f9a86 to
5a7b737
Compare
|
Thank you @Coosos. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 24, 2019
…constraint and mime types option (Coosos) This PR was squashed before being merged into the 4.4 branch (closes #32587). Discussion ---------- [Form][Validator] Generate accept attribute with file constraint and mime types option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes | Fixed tickets | #29327 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Generate the html `accept` attribute based on the file constraint and mime types option. Is it necessary to add this feature in the documentation ? Made with @Timherlaud _Sorry I have recreated this pull request because I missed my rebase_ Commits ------- 5a7b737 [Form][Validator] Generate accept attribute with file constraint and mime types option
Merged
yceruto
added a commit
that referenced
this pull request
Jul 25, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Typo in variable name | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | Refs #32587 Commits ------- 784d1d0 Typo in variable name
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the html
acceptattribute based on the file constraint and mime types option.Is it necessary to add this feature in the documentation ?
Made with @Timherlaud
Sorry I have recreated this pull request because I missed my rebase