[FrameworkBundle][Routing] Private service route loaders #32598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Jul 18, 2019
fancyweb
commented
Jul 18, 2019
fancyweb
commented
Jul 18, 2019
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php
Outdated
Show resolved
Hide resolved
ee02b90 to
55fe67c
Compare
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 19, 2019
…yweb) This PR was merged into the 4.3 branch. Discussion ---------- [Routing] Be consistent in custom route loader doc To be consistent with the above name "The routes defined using service route loaders will be automatically..." + cf symfony/symfony#32598 (comment) Commits ------- d60e4f6 [Routing] Be consistent in custom route loader doc
fbf1e07 to
ce1ca10
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php
Outdated
Show resolved
Hide resolved
7f90d08 to
ab43370
Compare
nicolas-grekas
approved these changes
Jul 31, 2019
ab43370 to
5d8595b
Compare
5d8595b to
64aa2c8
Compare
fabpot
approved these changes
Aug 9, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2019
…rs (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][Routing] Private service route loaders | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30402 | License | MIT | Doc PR | symfony/symfony-docs#11337 Continuation of #30926. ~Please review only the 2nd commit, I'm building this on top of #32582 Commits ------- 64aa2c8 [FrameworkBundle][Routing] Private service route loaders
nicolas-grekas
added a commit
that referenced
this pull request
Aug 11, 2019
…fancyweb) This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] Remove legacy route loader container | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Removes deprecations from #32598 Commits ------- 8bfb3a6 [FrameworkBundle] Remove legacy route loader container
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #30926.
Please review only the 2nd commit, I'm building this on top of #32582.