[Routing] Service route loaders tag #11337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Seems like you changed the single to double colon thing in both of your PRs. Can you remove it from one PR? (and if it's deprecated in 3.4 or 4.2, maybe create a new PR with that change based on the correct branch?) |
wouterj
reviewed
Apr 7, 2019
fc952d2 to
e51a3f6
Compare
|
@wouterj it has been deprecated since 4.1. I will create another MR for a fix on 4.2. |
wouterj
approved these changes
Apr 10, 2019
e51a3f6 to
eb1cd3d
Compare
|
The code has been approved but with a change in the tag name. I just updated the doc accordingly. |
OskarStark
approved these changes
May 6, 2019
eb1cd3d to
4aee349
Compare
|
@fancyweb does it now belong to: symfony/symfony#32582 ? |
|
No it's for symfony/symfony#32598 |
|
Ok, thank you, so the label |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 9, 2019
…rs (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][Routing] Private service route loaders | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30402 | License | MIT | Doc PR | symfony/symfony-docs#11337 Continuation of #30926. ~Please review only the 2nd commit, I'm building this on top of #32582 Commits ------- 64aa2c8 [FrameworkBundle][Routing] Private service route loaders
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Aug 9, 2019
…rs (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][Routing] Private service route loaders | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#30402 | License | MIT | Doc PR | symfony/symfony-docs#11337 Continuation of symfony/symfony#30926. ~Please review only the 2nd commit, I'm building this on top of symfony/symfony#32582 Commits ------- 64aa2c8529 [FrameworkBundle][Routing] Private service route loaders
4aee349 to
8397b67
Compare
wouterj
added a commit
that referenced
this pull request
Aug 12, 2019
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 12, 2019
* upstream/4.4: [symfony#11337] Added a deprecation directive [Routing] Route loader service tag
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 12, 2019
* 4.4: Sort imports alphabetically cleaning up some use statements, etc Update routing.rst [symfony#11337] Added a deprecation directive [Routing] Route loader service tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#eufossa
doc for symfony/symfony#32598