[TwigBundle] remove deprecations and fix tests #32696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d73c722 to
78e71a2
Compare
78e71a2 to
452f66d
Compare
Tobion
commented
Jul 24, 2019
|
|
||
| $code = $exception->getStatusCode(); | ||
|
|
||
| return new Response($this->twig->render( |
There was a problem hiding this comment.
Marked the controller as internal in #32695 so the twig dependency can easily be removed in master
nicolas-grekas
approved these changes
Jul 24, 2019
fabpot
approved these changes
Jul 24, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [TwigBundle] remove deprecations and fix tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | yes <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Removing deprecations from #31398 which should also fix tests in master as I removed some legacy code like (`exception_controller: ~ # to be removed in 5.0 relying on default`) while resolving conflicts when merging 4.4 into master. Commits ------- 452f66d [TwigBundle] remove deprecations
Tobion
added a commit
that referenced
this pull request
Jul 25, 2019
…precated templates (yceruto) This PR was squashed before being merged into the 5.0-dev branch (closes #32714). Discussion ---------- [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up #32696, Require merge 4.4 into master after #32695 to make WebProfilerBundle work properly in master. Commits ------- 0222860 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecations from #31398 which should also fix tests in master as I removed some legacy code like (
exception_controller: ~ # to be removed in 5.0 relying on default) while resolving conflicts when merging 4.4 into master.